From 11b5f0607464b407149963b6e3cb0ef7a1d69535 Mon Sep 17 00:00:00 2001 From: Tshepang Lekhonkhobe Date: Thu, 18 Aug 2016 08:46:42 +0200 Subject: [PATCH] match block not needed --- src/cargo/ops/cargo_doc.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/cargo/ops/cargo_doc.rs b/src/cargo/ops/cargo_doc.rs index 2ce18102a..f89dfac78 100644 --- a/src/cargo/ops/cargo_doc.rs +++ b/src/cargo/ops/cargo_doc.rs @@ -82,12 +82,11 @@ fn open_docs(path: &Path) -> Result<&'static str, Vec<&'static str>> { use std::env; let mut methods = Vec::new(); // trying $BROWSER - match env::var("BROWSER"){ - Ok(name) => match Command::new(name).arg(path).status() { + if let Ok(name) = env::var("BROWSER") { + match Command::new(name).arg(path).status() { Ok(_) => return Ok("$BROWSER"), Err(_) => methods.push("$BROWSER") - }, - Err(_) => () // Do nothing here if $BROWSER is not found + } } for m in ["xdg-open", "gnome-open", "kde-open"].iter() { -- 2.30.2